]> git.koha-community.org Git - koha.git/commit
Bug 19258: Prevent warns when writing off an individual fine
authorAleisha Amohia <aleishaamohia@hotmail.com>
Tue, 5 Sep 2017 22:34:18 +0000 (22:34 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 7 Sep 2017 17:39:09 +0000 (14:39 -0300)
commit693cc1122b2b96ef2fc176b07371a4608104eaaf
tree779029c5e200a88aba1b7e0e4f7f33bd30b14498
parent9ffda7a7bc9f627165954b8272f1bb71c1b2beff
Bug 19258: Prevent warns when writing off an individual fine

The following warns are triggered when I click the Write Off button next
to an individual fine or charge:
CGI::param called in list context from package
CGI::Compile::ROOT::home_vagrant_kohaclone_members_pay_2epl line 171,
this can lead to vulnerabilities. See the warning in "Fetching the
value or values of a single named parameter" at
/usr/share/perl5/CGI.pm line 436. (this shows many times)
Use of uninitialized value in subroutine entry at
/usr/share/perl5/URI/Escape.pm line 184.

To test:
1) Go to a members detail page in staff side and create a manual
invoice
2) Go to the pay fines tab, click the Write off button next to the
invoice you just created
3) Notice warns
4) Apply patch and repeat steps 1 & 2
5) Warns should be gone

Sponsored-by: Catalyst IT
Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
members/pay.pl