]> git.koha-community.org Git - koha.git/commit
Bug 32721: (QA follow up) - fix QA issues
authorMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Fri, 27 Jan 2023 14:46:44 +0000 (14:46 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Thu, 19 Oct 2023 19:00:54 +0000 (16:00 -0300)
commit6deab09c1317f202252afee99d06af5cdb533af0
treebb43496390b0ce98033dc6aa5afd127db4805f01
parentdd3d59f1f87a12b8d335e48ced08c9fd3f09bf65
Bug 32721: (QA follow up) - fix QA issues

This patches addresses issues raised by the QA tests. It also adds a missed import of the Branches file in the document head

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 32721: (QA follow-up) Add missing imports

Missing imports added in three template files
Exec flag added to atomic update file
Tinymce imports removed

A new bug will be created to move codemirror into an inc file at latest
version

Test plan as before

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Bug 32721: Tidy up - duplicate fetching of userjs and css

Currently UserJS and UserCSS is injected into the template as a parameter through Auth.pm but is then fetched using Koha.Preference() in the template. This patch tidies this up by removing the parameters from Auth.pm

Test plan as per first commit

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
C4/Auth.pm
koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
koha-tmpl/opac-tmpl/bootstrap/en/includes/doc-head-close.inc
koha-tmpl/opac-tmpl/bootstrap/en/modules/sci/sci-main.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/help.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
t/db_dependent/Template/Plugin/Branches.t