]> git.koha-community.org Git - koha.git/commit
Bug 14801: Fix Reserves.t -- Follow-up for ChargeReserveFee
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 14 Sep 2015 09:11:11 +0000 (11:11 +0200)
committerTomas Cohen Arazi <tomascohen@unc.edu.ar>
Wed, 16 Sep 2015 13:19:38 +0000 (10:19 -0300)
commit70133ef343e7885b4d237e51351bf05f4e490850
tree1ae47e94dbcd9e017e5bcba1e1959fe05fa2e0aa
parent8b710d62d1414a89b686f3a440bf03552e7e1d04
Bug 14801: Fix Reserves.t -- Follow-up for ChargeReserveFee

The problem making some tests fail, actually was the unneeded addition
of zero accountline records by ChargeReserveFee, called by AddReserve.
The balance is still zero, but a test like !$var responds differently
when var is 0.00 instead of 0 or undef.

This patch adjusts the test in ChargeReserveFee in order to prevent
adding these records with 0.00.
The first patch that adjusts the tests in Reserves.t is not strictly
needed anymore, but can stay.

Test plan:
[1] Run t/db_dependent/Reserves.t
[2] Run t/db_dependent/Reserves/GetReserveFee.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
C4/Reserves.pm