]> git.koha-community.org Git - koha.git/commit
Bug 22927: Do not check an already lost item when marked as withdrawn or damaged
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sat, 8 Jun 2019 20:34:24 +0000 (15:34 -0500)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Wed, 9 Oct 2019 13:29:53 +0000 (14:29 +0100)
commit759790c97aee0c5e7d768459f3cf7525961666ef
treedd4dddc62329e4b622dd9ba6b798aa027fcf8c67
parentce8896f17d99cbbc663b8cc59110ce01d8e70afd
Bug 22927: Do not check an already lost item when marked as withdrawn or damaged

Due to how moredetail.pl was written it was hard to know which action
was triggered.

Test plan:
- Set MarkLostItemsAsReturned to "from the items tab of the catalog
module."
- Check an item out to a patron
- Use additem.pl to set that item to a lost status without returning it
- go to moredetail.pl for that item
- mark item as either damaged or withdrawn without interacting with the
lost dropdown
- note that item has not been returned

Note for QA: Maybe we could have just tested if exists $item_changes->{'itemlost'}
to call LostItem

Signed-off-by: Claudie Trégouët <claudie.tregouet@biblibre.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
catalogue/updateitem.pl
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt