]> git.koha-community.org Git - koha.git/commit
Bug 34571: Remove use of "onclick" for ExpandField in cataloguing editors
authorDavid Cook <dcook@prosentient.com.au>
Fri, 18 Aug 2023 04:32:31 +0000 (04:32 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 30 Aug 2023 13:07:08 +0000 (10:07 -0300)
commit8341ffe13db350f3d0c623e1f6ff6671e1944d82
tree6e5ee46e745231b5a8880e90c55b91ee93880700
parent0b992dd12ed657a9af516bac6a507bab395e9add
Bug 34571: Remove use of "onclick" for ExpandField in cataloguing editors

This change replaces the onclick HTML attribute with a Javascript binding
to make it more in line with Koha conventions and make it CSP compatible.

Test plan:
0. Apply patch
1. Go to http://localhost:8081/cgi-bin/koha/cataloguing/addbiblio.pl?frameworkcode=#
2. Try hiding/unhiding fields
3. Try cloning fields and hiding/unhiding those too
4. Note that everything works as expected
5. Do the same thing for authorities by going to
http://localhost:8081/cgi-bin/koha/authorities/authorities.pl?authtypecode=#

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/addbiblio.tt
koha-tmpl/intranet-tmpl/prog/js/cataloging.js