]> git.koha-community.org Git - koha.git/commit
Bug 2426: Remove deprecated management permission
authorKatrin Fischer <katrin.fischer.83@web.de>
Tue, 15 May 2018 23:19:53 +0000 (01:19 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 8 Jun 2018 12:17:25 +0000 (12:17 +0000)
commit870913b3c3a83568c219d6e22b7110ffd217370c
treed3926b5f741886df43d5212d818f09d94251961b
parent20bd2d2bd50e4e8b4f8b40e7d1df521a0e01bc09
Bug 2426: Remove deprecated management permission

After review of the code it turns out that the management permission
that has been marked as deprecated a long time ago, does not have
any function.

The patch removes all remaining code related to it.

To test:
- Make sure you have a patron with the management permission
- Apply patch
- Run database update
- Check everything still works as expected

Bonus:
borrowers.flags is recalculated for patrons with management
permission.

To check:
- Create some 'permission twins' with and without management
  permission
- Note the value in borrowers.flags
- Apply patch, don't run database update
- Save permissions from GUI for one of the twins
- Note the newly calculated value
- Run database update
- Now both twins should have the same borrowers.flags value

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
C4/Auth.pm
C4/InstallAuth.pm
installer/data/mysql/userflags.sql
koha-tmpl/intranet-tmpl/prog/en/includes/header.inc
koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
koha-tmpl/intranet-tmpl/prog/en/modules/help/members/member-flags.tt
t/db_dependent/Auth.t
t/db_dependent/Search/History.t