]> git.koha-community.org Git - koha.git/commit
Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 15 Mar 2019 22:37:52 +0000 (19:37 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Tue, 14 Apr 2020 15:39:06 +0000 (16:39 +0100)
commit91f9f8cdfd1ecbf56bbc4771d7c58cd9b468fc64
tree8a4078015a17bac6b29ca0b4dd635a8c38ed4ac3
parent220c4906bf1bc399e639d5bd1c2c84319c54e3b8
Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent

There are 2 subroutines from C4::Acquisition that could be removed:
- GetLastOrderReceivedFromSubscriptionid
- GetLastOrderNotReceivedFromSubscriptionid

After bug 20726 only GetLastOrderReceivedFromSubscriptionid will be used
(from acqui/neworderempty.pl) and this call could be replaced easily with Koha::Acquisition::Orders

The code (+ tests) related to these 2 subroutines could then be removed.

The parameters for the search is basic and does no really deserve its own subroutine.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
acqui/neworderempty.pl
t/db_dependent/Acquisition/OrderFromSubscription.t