]> git.koha-community.org Git - koha.git/commit
Bug 30694: Set decreaseloanholds undef when deleting circulation rule
authorEmmi Takkinen <emmi.takkinen@koha-suomi.fi>
Tue, 15 Nov 2022 07:31:13 +0000 (09:31 +0200)
committerTomas Cohen Arazi <tomascohen@theke.io>
Fri, 23 Dec 2022 17:01:43 +0000 (14:01 -0300)
commit91fc31c32ba14817d989bcd34854ebc8e41fa936
tree5c22bd3793f1cabdb0a4e552258ebfeacd7f80b1
parentaff2be24b76d98b03d731a13b3be4ed75f2f03db
Bug 30694: Set decreaseloanholds undef when deleting circulation rule

When one tries to delete rule with field "Decreased loan period
for high holds" filled, delete fails without errors. This happens
because rule isn't set in code section handling the delete in
smart-rules.pl.

To test:
1. Create a new circulation rule and fill all fields.
2. Try to delete the rule.
=> Rule isn't deleted, all fields except "Decreased loan period
for high holds" are now empty or have value "Unlimited".
3. Modify the rule and set field "Decreased loan period for high
holds" empty.
4. Delete the rule.
=> Rule is deleted successfully.
5. Create a new rule, fill all fields expect field "Decreased loan
period for high holds".
6. Delete the rule.
=> Rule is deleted successfully.
7. Apply this patch.
8. Again create a new rule with field "Decreased loan period for high holds" filled.
9. Try to delete the rule.
=> Rule is deleted successfully.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
admin/smart-rules.pl