]> git.koha-community.org Git - koha.git/commit
Bug 29018: Make DELETE /patrons/:patron_id check things
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 20 Dec 2021 15:05:59 +0000 (12:05 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Wed, 5 Jan 2022 23:33:46 +0000 (13:33 -1000)
commit942d7cd8a69b222ca9b914970bee2b8cf5b65acf
tree2b51f4a3489de0be034d9c6471eaf8eeba0b35db
parenta0a8e08989dd77bba28a7f236268dd74767e9053
Bug 29018: Make DELETE /patrons/:patron_id check things

When the route was implemented, the checks were overlooked. This patch
adds checks for:
- Guarantees
- Debts
- Current checkouts

Any of those will block deletion, as it should.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/patrons.t
=> FAIL: Tests fail, the route misses checks
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The three conditions prevent deletion!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/REST/V1/Patrons.pm
api/v1/swagger/paths/patrons.yaml