]> git.koha-community.org Git - koha.git/commit
Bug 11891: (follow-up) remove custom storage class
authorGalen Charlton <gmc@esilibrary.com>
Wed, 18 Jun 2014 22:25:22 +0000 (22:25 +0000)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 19 Jun 2014 14:55:03 +0000 (11:55 -0300)
commit967f5cb51321a6a08176c7718a6ab933b3b5f926
treec76a9f0e2650441dec37304f8bcc1c640238b229
parenta10f6858e1a1f7096af19845362ded66a4343b33
Bug 11891: (follow-up) remove custom storage class

For now, just rely on the normal DBIx::Class cleanup handler;
otherwise, the following warning is displayed in logs:

  (in cleanup) Can't locate object method "_preserve_foreign_dbh" via package "Koha::Storage" at .../Koha/Storage.pm

Using the default DBIC storage class also means that we
don't have to manually do things like set the SQL limit dialect;
meaning that we don't get the following warning message:

  DBIx::Class::ResultSet::find(): Your storage class (Koha::Storage) does
  not set sql_limit_dialect and you have not supplied an explicit
  limit_dialect in your connection_info. DBIC will attempt to use the
  GenericSubQ dialect, which works on most databases but can be (and
  often is) painfully slow. Please file an RT ticket against
  'Koha::Storage' . at /home/gmc/koha/C4/Members.pm line 840

Test plan: same as main patch

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Koha/Schema.pm
Koha/Storage.pm [deleted file]