]> git.koha-community.org Git - koha.git/commit
Bug 18382: (QA follow-up) Replace ->ymd by ->datetime
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 22 Mar 2018 08:17:46 +0000 (09:17 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 2 Apr 2018 21:07:46 +0000 (18:07 -0300)
commit9a07da768c52c0f79130b465bc46a8578c80c487
treeb38c804da581b72641cda337cf6a7352eb5ab558
parent2deaead2566a62ce7772cd15a5ffbeb6216a539a
Bug 18382: (QA follow-up) Replace ->ymd by ->datetime

The first patch makes Hold.t fail on:
not ok 8 - Hold is suspended with a date, truncation takes place automatically
   Failed test 'Hold is suspended with a date, truncation takes place automatically'
   at Hold.t line 94.
          got: '2018-03-22'
     expected: '2018-03-22T00:00:00'

We could remove the midnight time there, but we also could replace ymd by
datetime. The cpan doc tells us:
    Same as $dt->ymd('-') . 'T' . $dt->hms(':')

Test plan:
With this patch, run Hold.t again. It should pass now.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Hold.pm