]> git.koha-community.org Git - koha.git/commit
SIP Holds processing on checkout
authorJoe Atzberger (siptest <atz4sip@arwen.metavore.com>
Thu, 9 Oct 2008 22:53:37 +0000 (17:53 -0500)
committerGalen Charlton <galen.charlton@liblime.com>
Tue, 14 Oct 2008 18:02:51 +0000 (13:02 -0500)
commit9bef3f6cf0f66acd99bc633976a9c629f974059f
tree208ec8f3c01c60b0d2d0bbfac2a38319322231ef
parentb165e9802fece8b21278775f48a99d43fe932f9d
SIP Holds processing on checkout

Allow valid comparison of hold_queue to current user barcode and
permit checkout if the current user is at the front of the queue.
Effectively, this allows a user to checkout a book he has held.
Here are the example checkout (11) and checkout response (12)
statements in a SIP telnet session, showing failure (120) previously
and success (121) after patch application.
Before:
11YN20060329    203000                  AOCPL|AA1|AB502326000820|ACterm1
120NUN20081009    140222AOCPL|AA1|AB502326000820|AJKidnapped :|AH|AF2008-10-09 : Koha Admin (1)|BLY|
After:
11YN20060329    203000                  AOCPL|AA1|AB502326000820|ACterm1
121NNY20081009    150204AOCPL|AA1|AB502326000820|AJKidnapped :|AH2008-10-10|AFItem was reserved for you.|

This patch also resolves security/privacy issues related to the display
of "needsconfirmation" values that identify, for example, the user
currently issued an item, or with a hold on the item.  These messages
should not be passed to an end-user interface.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
C4/SIP/ILS.pm
C4/SIP/ILS/Item.pm
C4/SIP/ILS/Patron.pm
C4/SIP/ILS/Transaction/Checkout.pm