]> git.koha-community.org Git - koha.git/commit
Bug 23099: OPAC Search result sorting "go" button flashes on page load
authorOwen Leonard <oleonard@myacpl.org>
Tue, 11 Jun 2019 18:13:08 +0000 (18:13 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 9 Aug 2019 14:51:35 +0000 (16:51 +0200)
commita00b6b155617f686c2a67a4b2b9c985b7d851bd2
tree8644d847d4c7639d1d49287c682ae48e9f67d0fc
parentc1d1a52cf27432c8f922e09d12b7a283a27a5313
Bug 23099: OPAC Search result sorting "go" button flashes on page load

There are a few places in the OPAC where we hide the submit button on a
sorting form because the form auto-submits when the selection changes.
These should be hidden using CSS instead of JS to prevent the temporary
appearance of the submit button while the page loads.

To test, apply the patch and rebuild the OPAC CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Test OPAC search results and OPAC checkout history. On both pages you
should not see a "Go" button next to the <select> input for changing the
sort order.

Disable JavaScript in your browser and test those pages again. The "Go"
button should appear.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit a89a203c1c85841a09b49771adbd77eeb76180c2)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-readingrecord.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt