]> git.koha-community.org Git - koha.git/commit
Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Fri, 17 May 2019 07:36:17 +0000 (07:36 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 13 Sep 2019 12:36:11 +0000 (14:36 +0200)
commita1927fdf46c015fb1382aaa7bf63768088a7e19c
treece1742047db302b831ee67d964020dfdec221dcf
parent1a16ac1b7df407e2456e8692a0aca512a61cbf2b
Bug 22929: Allow SCI/SCO logins independent of GDPR_Policy

This patch makes Auth skip the GDPR policy check when get_template_and_user
is called for sci/sco (self checkin, checkout).
I do not really like the change in this form but the nature of self checkin
and checkout kind of dictate it (double hack).
I wanted to add a test but since that asks for mocking CGI, checkauth, etc.
the time needed for that is just too much for this simple change.

Test plan:
Enable GDPR_Policy and self checkin/checkout.
Verify that using patrons without consent is not blocking sci/sco.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit 3640130d1fbc49ddc2cc4baef53a4c4d7fea76bf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Auth.pm