]> git.koha-community.org Git - koha.git/commit
Bug 26584: Remove unused C4::Acquisition::CloseBasket function
authorTomas Cohen Arazi <tomascohen@theke.io>
Wed, 30 Sep 2020 18:39:05 +0000 (15:39 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 5 Nov 2020 14:24:20 +0000 (15:24 +0100)
commita851aaeebf60e2da4ea9381151521e5f03a994c8
treecce91f7d25531998663b811b2eb56fe11032e1ee
parent83bb93ccc96b69739900af559c5112602bc13490
Bug 26584: Remove unused C4::Acquisition::CloseBasket function

This patch makes code use the new Koha::Acquisition::Basket->close
method and makes CloseBasket obsolete.

It then removes it, and adapts the few places in which it was used.

1. Apply this patch
2. Run:
   $ kshell
  k$ git diff origin/master --name-only | grep -e '\.t$' | xargs prove
=> SUCCESS: Tests pass!
3. Try playing with baskets, closing them
=> SUCCESS: All works as expected!
4. Sign off :-D

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Acquisition.pm
Koha/EDI.pm
acqui/basket.pl
t/db_dependent/Acquisition.t
t/db_dependent/Acquisition/GetBasketsInfosByBookseller.t
t/db_dependent/Acquisition/close_reopen_basket.t
t/db_dependent/Letters.t