]> git.koha-community.org Git - koha.git/commit
Bug 11889: (follow-up) Get rid of FIXME in Koha::Patron
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 9 Jun 2022 07:24:31 +0000 (07:24 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 19 Jul 2022 14:00:16 +0000 (11:00 -0300)
commitaff32dd6dddb54ec418a48226f0b300cab57bcd6
treec2bd4e95636e7f5f96948a6456c6b886243bab15
parent1d1432cfb5ff5e8cae6443a7ce4095eeec18e787
Bug 11889: (follow-up) Get rid of FIXME in Koha::Patron

Instead of get_lists, I added ->virtualshelves.

I removed the addition of the suffix to the shelf name here; if we
really want that (doubts), we should do it pref based. Removing a
staff member with public lists would result in weird names with
shelf numbers on the OPAC. (Should be very easy to restore.)

Used this opportunity to refactor the patron->delete subtest a bit:
switching to build_object, removing the 'retrieved patrons',
differentiating between staff patron and patron for sharing,
adding a few tests.

Test plan:
Enable transfer ownership. Delete a patron with lists in interface.
Check what happened.
Run t/db_dependent/Koha/Patrons.t.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Patron.pm
t/db_dependent/Koha/Patrons.t