Bug 23771: Don't look for patrons if we don't have a userid
authorNick <nick@bywatersolutions.com>
Mon, 7 Oct 2019 20:09:04 +0000 (20:09 +0000)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 8 Nov 2019 14:40:57 +0000 (15:40 +0100)
commitb3d6acc3de8a90cbb72e7aec5a5cc9c098ce0e0b
tree2607927cf4bc219cfbdca46fb10bf9f17c133a21
parentb117a39f6936da0b67ac258a6677baf90549b20f
Bug 23771: Don't look for patrons if we don't have a userid

While the code requires external auth to test, the change is simple enough I
think a good read would suffice

To test:
1 - You either need Shib or CAS enabled and setup
2 - Add two users with blank.null cardnumbers
3 - Lock those user accounts
    Set failedloginattempts to 1
    Try a bad login with the userid
    Or set via the DB
4 - Try a good login via the external auth
5 - Note it fails
6 - Apply patch
7 - Login now succeeds

Signed-off-by: Mike Somers - Bridgewater State University <msomers@bridgew.edu>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit c9c6dd10167bc4c60cb384651f4dc802944c4228)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
C4/Auth.pm