]> git.koha-community.org Git - koha.git/commit
Bug 34043: Remove incorrect spaces
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 4 Sep 2023 12:30:14 +0000 (09:30 -0300)
committerTomas Cohen Arazi <tomascohen@theke.io>
Mon, 4 Sep 2023 12:30:18 +0000 (09:30 -0300)
commitb46418478ed5c0b28360aa6d0a01c1042f1bd28d
tree9a3528f88d05984694de5b462f7fa2fbe9c2d9e2
parent1ca21fabb2a521b6c206b85e3f1feaffb2380e75
Bug 34043: Remove incorrect spaces

This bug looked cool and safe, but tests highlighted that the
(introduced) newlines were translated into spaces, which is not correct
in the CSV format (i.e. q{"Column 1" , "Column 2"} is not really
correct).

Also, the double quotes were forcibly introduced (semi-correct) but the
tests weren't adjusted.

We should really stop using templates for generating CSV, and use a
library for the task instead of manually crafting them. But that's for
another bug report.

This patch:

* Removes extra spaces in TT-generated CSV headers
* Adjusts the tests to the new format introduced by this report

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/basket.tt
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/basketgroup.tt
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/acqui/lateorders.tt
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/catalogue/itemsearch.tt
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/cash_register_stats.tt
koha-tmpl/intranet-tmpl/prog/en/includes/csv_headers/reports/orders_by_budget.tt
t/db_dependent/Acquisition/GetBasketAsCSV.t
t/db_dependent/Acquisition/GetBasketGroupAsCSV.t