]> git.koha-community.org Git - koha.git/commit
Bug 16441: Do not use a package variable to cache C4::Letters::getletter
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 4 May 2016 18:43:43 +0000 (19:43 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 10 Jun 2016 16:41:28 +0000 (16:41 +0000)
commitc4f388f64966f2202e9f3e3c16dad5cef3dbe0ac
tree0f44011cb4739154b05a10c988d6f93500a28032
parent113adf68e56b6233b44a2b7a9b5dc60f6c4de0b7
Bug 16441: Do not use a package variable to cache C4::Letters::getletter

C4::Letters::getletter use a package variable (%letter) to cache letter
returned by the subroutine.
I have not found any direct issues caused by that but it is safer to
remove it.
It won't be a big deal to hit the DBMS to get a valid letter when
needed.

No test plan here, just confirm that the changes make sense.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Confirm that performance loss is just a millisecond or so per
subsequent call of getletter.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Letters.pm