]> git.koha-community.org Git - koha.git/commit
Bug 13757: (followup) Only touch opac_editable attributes
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 23 Dec 2016 19:19:06 +0000 (16:19 -0300)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 24 Mar 2017 18:45:01 +0000 (18:45 +0000)
commitc8889f0ff7cfb83422f0136faaf1be9cdec5515c
treeaeb9cc2fab52881a5fd6e1fec6c46ef5efcaf698
parent925e664f42ff9546624946258fe27263e6041fa3
Bug 13757: (followup) Only touch opac_editable attributes

As reported by Owen, the members-update.pl was showing every attributes
the patron has (display issue) instead of showing only those affected by
the changes.

This patch fixes this by filtering the patron's attributes by opac
editability.

It also fixes Koha::Patron::Modification->approve so it only clears the
attributes with the updating 'code' and leaves the others untouched.
As its been coded so far (until someone refactors it all) the
Koha::Patron::Modification object needs to contain all the attributes
for a specific code. And it comes from parsing the UI's input.

Tests for Koha::Patron::Modification->approve to come.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Koha/Patron/Modification.pm
members/members-update.pl