]> git.koha-community.org Git - koha.git/commit
Bug 26738: (bug 24819 follow-up) Fix manager selection
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 2 Nov 2020 14:01:32 +0000 (15:01 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 4 Nov 2020 11:59:32 +0000 (12:59 +0100)
commitcd742a15dd0a889b158f4e841918175763ae83f9
treec8b2baff2440984fbecced4f4799eb6eff5a0a27
parent20431a03360583b705d3e2b2e3a60b2ff1f29474
Bug 26738: (bug 24819 follow-up) Fix manager selection

Bug 23590 added a new feature to select the manager of a suggestion.
One month later bug 24819 added the ability to pick the suggester.

This second patchset broke the manager selection.

This patch simplifies the way the suggester is selected, using the
generic way and mimicking what is done for the manager.

Test plan:
- create a new purchase suggestion from within acquisitions (suggestion.pl?op=add)
- click "select manager," search for user, click Select
- see that the user you just selected shows under "Created by,"
- see that "Managed by" still says "You"
- modify the suggester
- save your suggestion
=> Everything is saved correctly

QA will test the permission alert:
Edit suggestion.tt and remove "&permissions=suggestions.suggestions_manage"
Edit the suggestion, select a manager, pick a patron in the list who
does not have sufficient permissions, save
=> you get the alert

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
koha-tmpl/intranet-tmpl/prog/en/modules/common/patron_search.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/tables/suggester_search.tt [deleted file]
koha-tmpl/intranet-tmpl/prog/js/suggestions.js [deleted file]
suggestion/add_user_search.pl
suggestion/suggester_search.pl [deleted file]
suggestion/suggestion.pl