]> git.koha-community.org Git - koha.git/commit
Bug 13161 - Report name should be mandatory when editing saved reports
authorOwen Leonard <oleonard@myacpl.org>
Wed, 29 Oct 2014 17:34:03 +0000 (13:34 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Thu, 30 Oct 2014 03:39:30 +0000 (00:39 -0300)
commitd3edcf726fa69c5c8dcbba4637f3fae734c5b732
tree677b65bdd18cb2e634bf102929c547ea3bb3f6f7
parent32bb90604be79ea97dacc7a02dcbce392ea303fb
Bug 13161 - Report name should be mandatory when editing saved reports

When Bug 2969 made report name required for SQL reports, it did so only
for new reports. This patch makes the same requirement true when editing
existing reports.

Other changes:

- Removed unused "type" setting from edit screen (already removed from
  creation form).
- Added form field size attribute to report name field to match creation
  form.
- Moved SQL textarea into its own fieldset and marked it as required,
  matching the report creation form.

To test, apply the patch and edit an existing saved SQL report. You
should be prevented from saving your report with either the report name
or SQL field blank. Test with JavaScript enable and disabled.

Confirm that after entering valid data your report runs correctly.
Compare the new SQL report form with the update SQL report form. They
should be structured the same.

Signed-off-by: Nick Clemens <nick@quecheelibrary.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes tests and QA script. Works as described.

Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt