]> git.koha-community.org Git - koha.git/commit
Bug 23518: Problem with borrower search autocomplete
authorOwen Leonard <oleonard@myacpl.org>
Fri, 30 Aug 2019 12:25:45 +0000 (12:25 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Sat, 21 Sep 2019 11:59:01 +0000 (11:59 +0000)
commitd42974f5bb2cae2f05ec388dab662cdee18f9840
treed4a14639ae52c3eec9543bc933d43cb7f9b03354
parent297e2853e66402fd1cab6cc50faeb4abd1836025
Bug 23518: Problem with borrower search autocomplete

This patch fixes a bug introduced by my patch for Bug 23405: Keyboard
navigation of patron autocomplete results was broken because I
incorrectly assumed that the autocomplete "select" action was redundant
because keyboard navigation would trigger the selected link. It doesn't!

This patch adds the "select" action back to the autocomplete
configuration, explicitly defining a redirect to match the URL which is
followed if the user uses the mouse to click a result.

To test you should have a patron in your database which has no card
number. Make sure CircAutocompl is enabled.

- From the circulation home page, type a patron name in the "Check out"
  form and wait for autocomplete search results to display.

- Making a selection from the autocomplete results should work by
  clicking with a mouse OR using the arrow keys and TAB or ENTER.

- Test with patrons with and without card numbers.

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Michal Denar <black23@gmail.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
(cherry picked from commit b94b58aa746188ee3699a2e4bc0a6b24d2dd86c5)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit fec88c6414a7269a91d07388c00784c09bbb0494)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc