]> git.koha-community.org Git - koha.git/commit
Bug 10628: make sure AutomaticItemReturn doesn't prevent holds queue from filling...
authorKyle M Hall <kyle@bywatersolutions.com>
Tue, 23 Jul 2013 12:05:22 +0000 (08:05 -0400)
committerGalen Charlton <gmc@esilibrary.com>
Tue, 20 Aug 2013 15:31:38 +0000 (15:31 +0000)
commitd46657f8af980524a4351e40abe0b901d1af3e6a
treefeca321d00f309a7ed19580679c7c25f0233731e
parent7ae3ea68579b3f870d7e42968c3727ecffac7f02
Bug 10628: make sure AutomaticItemReturn doesn't prevent holds queue from filling local holds with local items

For some reason, C4::HoldsQueue::MapItemsToHoldRequests used the system
preference AutomaticItemReturn to decide if an attempt to fill local
holds with local items. No explanation of this behavior is provided.

This patch removes this behavior, and also adjusts the calculation
of the lead-cost library to always return the pickup library if it
is on the list of libraries that could fill the hold -- on the
basis that if the item is already at the pickup library, its
transport cost is inherently zero.

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Passes QA script and adds unit tests.
Tested with some examples and those worked correctly.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/HoldsQueue.pm
t/db_dependent/HoldsQueue.t