]> git.koha-community.org Git - koha.git/commit
Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 3 Sep 2018 09:49:08 +0000 (11:49 +0200)
committerNick Clemens <nick@bywatersolutions.com>
Fri, 7 Sep 2018 13:16:10 +0000 (13:16 +0000)
commitd6424c1999d3563c5243185503dd5a9b5b928f8f
tree2df6d1d6c0eb168dfeb1bdbfe0f369569f29e24b
parente85d6e12ea4dccd8fa08ec600864c2f985dcf886
Bug 17530: (QA follow-up) Add pref ArticleRequestsLinkControl

As requested by RM on Bugzilla comment53.

This pref allows you to always display the link on search results.
Which is the previous behavior ;) It will raise false positives, whereas
the algorithm may result in false positives or negatives (depending on
default item type and circulation rules).

When upgrading the pref is set to always (current behavior), new installs
get the new calc value using the algorithm in may_article_request.

Test plan:
Run t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t
Run t/db_dependent/ArticleRequests.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Koha/IssuingRules.pm
installer/data/mysql/atomicupdate/bug_17530.perl [new file with mode: 0644]
installer/data/mysql/sysprefs.sql
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
t/db_dependent/ArticleRequests.t
t/db_dependent/Koha/IssuingRules/guess_article_requestable_itemtypes.t