Bug 24257: Fix close of modal on 'Yes, print slip'
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Wed, 18 Dec 2019 09:37:00 +0000 (10:37 +0100)
committerJoy Nelson <joy@bywatersolutions.com>
Sun, 12 Jan 2020 19:15:33 +0000 (19:15 +0000)
commitdce1f12229eaa9370ce06b50248a433f778b3261
tree912605089b10e2c22c3d71753730ac1e9fa06857
parent57e69a7b2082e10e926a363c7ad14ccd435bb47c
Bug 24257: Fix close of modal on 'Yes, print slip'

When a item-transfer-modal is prompted by returns.tt and the option
"Yes, print slip" is selected the transfer is not initiated and the
modal does not disappear.

The print_slip hidden input must be in the same form as the
submit/button .print, otherwise the browser logs
  this.form.print_slip is undefined

Test plan:
1. set AutomaticItemReturn to "don't"
2. Check out an item and attempt to check it in at a branch it doesn't
belong to.
3. When the popup modal appears select 'Yes, print slip'.
=> Observe that the transfer does initiate and the modal closes

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joy Nelson <joy@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt