]> git.koha-community.org Git - koha.git/commit
Bug 9394: QA Followup
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 29 May 2013 12:38:40 +0000 (14:38 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 24 Jul 2013 05:04:56 +0000 (05:04 +0000)
commitdd2185981de2bf6e8d14bcdd4b6ae0da6cf2cbed
tree5f841b301d12d1a62cfb0586f94fa6e66fd5b4a0
parent53fbfa2dde3fb1150be9e49a90d9974bd71368a0
Bug 9394: QA Followup

* C4::Reserves::_FixPriority
  - The previous code checked the cancellationdate. If think you never pass
in it with bad parameters, but in order to be sure I added the check on
this value.
  - The reservedates array was never used.

* circ/circulation.tt
There was a bug: it was not possible to remove an hold from the
circulation page. Passing reserve_id fixes the issue.

* C4::Reserves::GetReserveId
This subroutine did not have a unit test.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
C4/Reserves.pm
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
t/db_dependent/Holds.t