]> git.koha-community.org Git - koha.git/commit
Bug 24242: Display funds that the logged in user can access - suggestions
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Sun, 15 Dec 2019 11:32:34 +0000 (12:32 +0100)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Mon, 23 Dec 2019 11:06:41 +0000 (11:06 +0000)
commite28f9861a94dc0428832cc15511d97cb9c51cfad
treef8405c019c1da9e55ee36fedc8d761ab1da6e366
parent92c6d3511ee42d9040fd8c4cda1fc1661024b075
Bug 24242: Display funds that the logged in user can access - suggestions

The design of this script is pretty bad and any modifications is a
challenge.
Here we are trying to display to display the funds available for the
logged in user. I did not understand previous code, as we are doing a
limit using CanUserUseBudget, I do not think it makes sense to retrieve
funds for a given library.
Also, I am wondering if the dropdown list in the filters has ever been
populated: budgetid_loop in the template *never* appeared in the history
of suggestion.pl (??)

Test plan:
Search for suggestions
Add/edit suggestions
=> The funds in the dropdown list should be the ones the logged in user
can use.

Signed-off-by: hc <hc@interleaf.ie>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
suggestion/suggestion.pl