]> git.koha-community.org Git - koha.git/commit
Bug 12623: SQLHelper replacement - Borrower::Modifications
authorYohann Dufour <dufour.yohann@gmail.com>
Fri, 8 Aug 2014 13:50:12 +0000 (15:50 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 11 Aug 2014 14:42:58 +0000 (11:42 -0300)
commitefee30f394bd89632e262d6605d4623a8ee2d9f9
treef4205c35d1e46b135a279651e773b073c8648acf
parentf95cd090b63e3491db8618efcc5faa3859fca322
Bug 12623: SQLHelper replacement - Borrower::Modifications

With this patch, the subroutines AddModification and ApproveModifications uses DBIx::Class instead of C4::SQLHelper.
Moreover, the tests has been wrapped in a transaction.

Test plan:
1) Apply the patch

2) Execute the unit tests by launching :
prove t/db_dependent/Koha_borrower_modifications.t

3) The result has to be a success without error or warning :
t/db_dependent/Koha_borrower_modifications.t .. ok
All tests successful.
Files=1, Tests=14,  2 wallclock secs ( 0.03 usr  0.01 sys +  1.60 cusr  0.08 csys =  1.72 CPU)
Result: PASS

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
Koha/Borrower/Modifications.pm
t/db_dependent/Koha_borrower_modifications.t