]> git.koha-community.org Git - koha.git/commit
Bug 27330: (follow-up) Cleanup missed on bug 23843
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 4 Jan 2021 14:29:38 +0000 (11:29 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 1 Feb 2021 15:36:38 +0000 (16:36 +0100)
commitf2593558952909f6c8df5d2ed8c6fea60cf7dcb9
tree7bfcb5987c84355c17f202d547b3ee0cdcb9c76c
parentea0696831fadd4b633c90fc7ccd29144e9a6b87a
Bug 27330: (follow-up) Cleanup missed on bug 23843

This patch makes some cleanup missed on bug 23843. The catch condition
on the controller was copied and pasted from other controller and should
be avoided unless there's a known case that needs special handling.
Otherwise it will be catched by the $c->unhandled_exception call.

All the old mappings were inadvertedly kept in the controller as well as
the (unused) _to_api method.

The base class is also cleaned from unnecessary mappings. Only mapped
things need to be added.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t \
           t/db_dependent/Koha/Club/Hold.t
=> SUCCESS: Tests pass!
3. Sign off :-D

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/Club/Hold.pm
Koha/REST/V1/Clubs/Holds.pm