]> git.koha-community.org Git - koha.git/commit
Bug 10806: make the staff benchmark script check authentication failure.
authorJonathan Druart <jonathan.druart@biblibre.com>
Thu, 29 Aug 2013 15:49:39 +0000 (17:49 +0200)
committerGalen Charlton <gmc@esilibrary.com>
Wed, 2 Oct 2013 15:30:49 +0000 (15:30 +0000)
commitf2c0fe0ca1c2ba720dbc02b533fa7b6b0f17e40b
treec6e1771ba8821a300da5d2760a1e14f986d3f079
parentbd5aec76494a10b6c908924b3a421f7ce08224f1
Bug 10806: make the staff benchmark script check authentication failure.

Currently, if you launch the script
misc/load_testing/benchmark_staff.pl, it always displays
"Authentication successful" or continue to execute the script even if
nothing is done.

This patch checks if the url is right and if the authentication is
correctly done.

Test plan:
Suppose that a correct login/pwd is koha/koha
1/
perl misc/load_testing/benchmark_staff.pl --steps=1
--url=http://admin.koha.local/cgi-bin/koha/
--password="koha" --user="koha"
should produce:
  Authentication successful
  ...
  Step 1
  ...

2/
perl misc/load_testing/benchmark_staff.pl --steps=1
--url=http://admin.koha.local/cgi-bin/koha/
--password="KOHA" --user="KOHA"
should produce:
Authentication failure: bad login/password

3/
perl misc/load_testing/benchmark_staff.pl --steps=1
--url=http://admin.kobe.local/cgi-bin/koha/
--password="koha" --user="koha"
should produce:
Authentication failure:
    500 Can't connect to admin.kobe.local:80 (Bad
    hostname)

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Comment: Works as described, detects bad url and user credentials.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described and gives better error messages.
There are some warnings output when running the script before
and after applying the patch.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
misc/load_testing/benchmark_staff.pl