Bug 23156: [18.11] Add pagination to checkouts in ILS-DI GetPatronInfo service
authorJulian Maurice <julian.maurice@biblibre.com>
Wed, 19 Jun 2019 10:07:58 +0000 (12:07 +0200)
committerLucas Gass <lucas@bywatersolutions.com>
Thu, 25 Jul 2019 20:43:05 +0000 (20:43 +0000)
commitf8b7a5f5e144e9539c1c7e7fd59904257b0ed33f
tree28f1ec5730ea89fd419256e24d1dd4db679bf51b
parenta7a6f941f1e5bf246692f0344666be2119c5bbea
Bug 23156: [18.11] Add pagination to checkouts in ILS-DI GetPatronInfo service

When patrons have a lot of checkouts, GetPatronInfo can take a lot of
time. This patch introduces two new parameters to allow pagination of
this list of checkouts

Also, fix a warning in C4::ILSDI::Services::GetPatronInfo

Test plan:
1. Go to /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X&show_loans=1
   where X is a borrowernumber of a patron who has several checkouts
   Verify that all checkouts are listed
2. Add '&loans_per_page=1&loans_page=1' to the URL. Verify that you have
   now only one checkout listed, and that there is a new element
   <total_loans> which contain the total number of checkouts
3. Increase the page number in the URL until you have seen all checkouts
4. prove t/db_dependent/ILSDI_Services.t

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
C4/ILSDI/Services.pm
opac/ilsdi.pl
t/db_dependent/ILSDI_Services.t