]> git.koha-community.org Git - koha.git/commit
Bug 29877: Make POST /holds handle maxreserves correctly
authorTomas Cohen Arazi <tomascohen@theke.io>
Thu, 13 Jan 2022 15:10:30 +0000 (12:10 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 4 Mar 2022 02:11:50 +0000 (16:11 -1000)
commitf8ea837b53b9756809d2a740e02a0ea4ceadb58f
treec5d9df8ac03ee62cabff34ccac92ece6325860ef
parent3ce1b0b707137960e95133f71dc9d48b232b06cb
Bug 29877: Make POST /holds handle maxreserves correctly

The current implementation doesn't consider the following values for the
syspref: undef and 0.

The tests mistakenly didn't cover them.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: Tests fail, obvious warnings about comparing undefined values
         too.
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. You can try on Postman as well
=> SUCCESS: Behavior is correct!
6. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/REST/V1/Holds.pm