]> git.koha-community.org Git - koha.git/commit
Bug 14464: Add ability to cancel waiting holds from checkin screen
authorJesse Weaver <pianohacker@gmail.com>
Tue, 9 Jun 2015 22:22:05 +0000 (16:22 -0600)
committerTomas Cohen Arazi <tomascohen@unc.edu.ar>
Fri, 21 Aug 2015 12:20:11 +0000 (09:20 -0300)
commitbb6277ffcc593685554112d770ac273c9efeda33
tree0ea82089ab891b99e302fb320633d0681e1a0e2e
parent3cbed1e65e7fb62ef8460ba64b810b4038e6d70e
Bug 14464: Add ability to cancel waiting holds from checkin screen

Test plan:

    1. Ensure that ExpireReservesMaxPickUpDelayCharge is set to 0.
    2. Place a hold (doesn't matter whether it's a bib/item-level hold),
       then confirm the hold by checking it in.
    3. Check in the item again, and hit Cancel.
    4. The reserve in question should be cancelled.
    5. Repeat steps 2-4 twice, once after setting
       ExpireReservesMaxPickUpDelayCharge to a nonzero value and again
       after clicking the "Forgive fees for manually expired holds"
       checkbox.

A fine should only be applied when the syspref is enabled and the
checkbox is not checked. Also, the checkbox should only appear after
enabling the syspref. And finally, the checkbox should remember whether
it is checked across multiple checkins, same as the "Forgive overdue
charges" and "Book drop mode" checkboxes.

Signed-off-by: Jason Burds <jburds@dubuque.lib.ia.us>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Amended patch: Removed 2 debugging lines.
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
C4/Reserves.pm
circ/returns.pl
koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt