From 2a9029faf1d40a8c477d669c462fef871f7fed93 Mon Sep 17 00:00:00 2001 From: hdl Date: Tue, 29 Mar 2005 14:21:37 +0000 Subject: [PATCH] Performance Improvements : Publisher lists and Item Codes becomes free input. --- .../default/en/reports/catalogue_stats.tmpl | 8 +- reports/catalogue_stats.pl | 98 +++++++++---------- 2 files changed, 53 insertions(+), 53 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/default/en/reports/catalogue_stats.tmpl b/koha-tmpl/intranet-tmpl/default/en/reports/catalogue_stats.tmpl index a038f5e646..d5c38eee00 100644 --- a/koha-tmpl/intranet-tmpl/default/en/reports/catalogue_stats.tmpl +++ b/koha-tmpl/intranet-tmpl/default/en/reports/catalogue_stats.tmpl @@ -64,7 +64,7 @@ Dewey Classification - From To + From To   @@ -88,7 +88,7 @@ LoC Classification - From To + From To   @@ -112,7 +112,7 @@ Callnumber - From To + From To   @@ -141,7 +141,7 @@ Publisher - + Publication Year diff --git a/reports/catalogue_stats.pl b/reports/catalogue_stats.pl index 55d6251c92..6c3dce3fe1 100755 --- a/reports/catalogue_stats.pl +++ b/reports/catalogue_stats.pl @@ -106,57 +106,57 @@ if ($do_it) { my %labels; my $count=0; my $req; - $req = $dbh->prepare("select distinctrow left(dewey,3) from biblioitems order by dewey"); + $req = $dbh->prepare("select count(dewey) from biblioitems "); $req->execute; my $hasdewey; my @select; - push @select,""; +# push @select,""; while (my ($value) =$req->fetchrow) { - $hasdewey =1 if (($value) and (! $hasdewey)); - $count++ if (($value) and (! $hasdewey)); - push @select, $value; + $hasdewey =1 if (($value>2) and (! $hasdewey)); + $count++ if (($value>2) and (! $hasdewey)); +# push @select, $value; } - my $CGIdewey=CGI::scrolling_list( -name => 'Filter', - -id => 'Filter', - -values => \@select, - -size => 1, - -multiple => 0 ); +# my $CGIdewey=CGI::scrolling_list( -name => 'Filter', +# -id => 'Filter', +# -values => \@select, +# -size => 1, +# -multiple => 0 ); - $req = $dbh->prepare( "select distinctrow left(lccn,3) from biblioitems order by lccn"); + $req = $dbh->prepare( "select count(lccn) from biblioitems "); $req->execute; - undef @select; - push @select,""; +# undef @select; +# push @select,""; my $haslccn; my $hlghtlccn; while (my ($value) =$req->fetchrow) { $hlghtlccn = !($hasdewey); - $haslccn =1 if (($value) and (! $haslccn)); + $haslccn =1 if (($value>2) and (! $haslccn)); $count++ if (($value) and (! $haslccn)); - push @select, $value; +# push @select, $value; } - my $CGIlccn=CGI::scrolling_list( -name => 'Filter', - -id => 'Filter', - -values => \@select, - -size => 1, - -multiple => 0 ); +# my $CGIlccn=CGI::scrolling_list( -name => 'Filter', +# -id => 'Filter', +# -values => \@select, +# -size => 1, +# -multiple => 0 ); - $req = $dbh->prepare("select distinctrow left(itemcallnumber,5) from items order by itemcallnumber"); + $req = $dbh->prepare("select count(itemcallnumber) from items"); $req->execute; - undef @select; - push @select,""; +# undef @select; +# push @select,""; my $hascote; my $hlghtcote; while (my ($value) =$req->fetchrow) { - $hascote =1 if (($value) and (! $hascote)); + $hascote =1 if (($value>2) and (! $hascote)); $count++ if (($value) and (! $hascote)); $hlghtcote = (($hasdewey) and ($haslccn)) or (!($hasdewey) and !($haslccn)); - push @select, $value; +# push @select, $value; } - my $CGIcote=CGI::scrolling_list( -name => 'Filter', - -id => 'Filter', - -values => \@select, - -size => 1, - -multiple => 0 ); +# my $CGIcote=CGI::scrolling_list( -name => 'Filter', +# -id => 'Filter', +# -values => \@select, +# -size => 1, +# -multiple => 0 ); $count++; my $hglghtDT =$count % 2; # warn "highlightDT ".$hglghtDT; @@ -187,18 +187,18 @@ if ($do_it) { -size => 1, -multiple => 0 ); - $req = $dbh->prepare("select distinctrow left(publishercode,75) from biblioitems order by publishercode"); - $req->execute; - undef @select; - push @select,""; - while (my ($value) =$req->fetchrow) { - push @select, $value; - } - my $CGIpublisher=CGI::scrolling_list( -name => 'Filter', - -id => 'Filter', - -values => \@select, - -size => 1, - -multiple => 0 ); +# $req = $dbh->prepare("select distinctrow left(publishercode,75) from biblioitems order by publishercode"); +# $req->execute; +# undef @select; +# push @select,""; +# while (my ($value) =$req->fetchrow) { +# push @select, $value; +# } +# my $CGIpublisher=CGI::scrolling_list( -name => 'Filter', +# -id => 'Filter', +# -values => \@select, +# -size => 1, +# -multiple => 0 ); undef @select; push @select,""; @@ -247,12 +247,12 @@ if ($do_it) { -multiple => 0 ); $template->param(hasdewey=>$hasdewey, - CGIFromDeweyClass => $CGIdewey, - CGIToDeweyClass => $CGIdewey, +# CGIFromDeweyClass => $CGIdewey, +# CGIToDeweyClass => $CGIdewey, haslccn=> $haslccn, hlghtlccn => $hlghtlccn, - CGIFromLoCClass => $CGIlccn, - CGIToLoCClass => $CGIlccn, +# CGIFromLoCClass => $CGIlccn, +# CGIToLoCClass => $CGIlccn, hascote=> $hascote, hlghtcote => $hlghtcote, hglghtDT => $hglghtDT, @@ -260,12 +260,12 @@ if ($do_it) { hglghtPY => $hglghtPY, hglghtHB => $hglghtHB, hglghtLOC => $hglghtLOC, - CGIFromCoteClass => $CGIcote, - CGIToCoteClass => $CGIcote, +# CGIFromCoteClass => $CGIcote, +# CGIToCoteClass => $CGIcote, CGIItemType => $CGIitemtype, # CGIFromPublicationYear => $CGIpublicationyear, # CGIToPublicationYear => $CGIpublicationyear, - CGIPublisher => $CGIpublisher, +# CGIPublisher => $CGIpublisher, CGIBranch => $CGIbranch, CGILocation => $CGIlocation, CGIextChoice => $CGIextChoice, -- 2.39.2