From 3133d4e46b023cac18ab37abfb81b77d18a5f53b Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 28 Mar 2017 11:05:28 +0000 Subject: [PATCH] Bug 18344: Allow overdue fines cap at replacement price, and cap by amount to work together There is no reason that a library shouldn't be able to use the monetary fines cap and the replacement price cap at the same time. The code is written in such a way that they already work harmoniously. We have librarians who wish to use both so they can set a high cap of $10.00 but also use the replacement price cap so that a $20.00 book would only get a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00 Test Plan: 1) Apply this patch 2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and a daily fine of $1 3) Create two items, one with a replacement price of $5 and one with a replacement price of $15 4) Check out these items to a patron, backdate the checkouts so they are already overdue by a couple months 5) Check the items in ( make sure calc fine at checkin is enabled for you ) 6) Note the one item has a fine of $5 and the other has a fine of $10! Signed-off-by: David Kuhn Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit e702ff89f77e50b1bcef1cdc1548627957251df0) Signed-off-by: Fridolin Somers (cherry picked from commit 9ea56e1cd958d225be0ba7e1861804b7ce7e8542) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 3 --- 1 file changed, 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 3b43f295f5..915f36e4f7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -822,9 +822,6 @@ } }); - $('#cap_fine_to_replacement_price').on('change', function(){ - $('#overduefinescap').prop('disabled', $(this).is(':checked') ); - }); $('#selectlibrary').find("input:submit").hide(); $('#branch').change(function() { $('#selectlibrary').submit(); -- 2.39.5