From 3ec8b27185f0c8600bc931c5284a5d73d0a42aac Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Tue, 4 Aug 2015 15:59:39 +0000 Subject: [PATCH] Bug 14644: unbreak SIP2 terminal login when using telnet transport This patch fixes breakage introduced by the patch for bug 13506 that prevented SIP2 clients from authenticating themselves over the telnet transport. Attempts to do so would manifest by the SIPServer backend crashing and the connection getting closed. To test: [1] Use the stock SIPServer config, etc/SIPconfig.xml, and ensure that the database contains a staff user whose username is 'term1' and password is 'term1' that has the circulate permission. [2] Start SIPServer, telnet to port 8023, and attempt to log in. The connection will be aborted: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Connection closed by foreign host. [3] Apply the patch and restart SIPSever, then repeat step 2. This time, the login should succeed: $ telnet localhost 8023 Trying 127.0.0.1... Connected to localhost. Escape character is '^]'. login: term1 password: term1 Login OK. Initiating SIP Signed-off-by: Galen Charlton Signed-off-by: Colin Campbell Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi --- C4/SIP/SIPServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/C4/SIP/SIPServer.pm b/C4/SIP/SIPServer.pm index 20a97c65a6..8722ab6b3d 100755 --- a/C4/SIP/SIPServer.pm +++ b/C4/SIP/SIPServer.pm @@ -205,7 +205,7 @@ sub telnet_transport { syslog("LOG_DEBUG", "telnet_transport 2: uid length %s, pwd length %s", length($uid), length($pwd)); if (exists ($config->{accounts}->{$uid}) - && ($pwd eq $config->{accounts}->{$uid}->password())) { + && ($pwd eq $config->{accounts}->{$uid}->{password})) { $account = $config->{accounts}->{$uid}; if ( C4::SIP::Sip::MsgType::login_core($self,$uid,$pwd) ) { last; -- 2.39.5