From 41e63c44e06fa17959b7cd1c9035c75b2577c633 Mon Sep 17 00:00:00 2001
From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Date: Tue, 17 Oct 2017 16:57:16 +0200
Subject: [PATCH] Bug 19463: Additional changes to gen_text

Use Bytes::Random::Secure instead of perl rand.
Return a string from 50 to 100% of $size.

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 t/lib/TestBuilder.pm | 27 +++++++++++++++------------
 1 file changed, 15 insertions(+), 12 deletions(-)

diff --git a/t/lib/TestBuilder.pm b/t/lib/TestBuilder.pm
index a4128469a0..d42372e59b 100644
--- a/t/lib/TestBuilder.pm
+++ b/t/lib/TestBuilder.pm
@@ -4,6 +4,7 @@ use Modern::Perl;
 
 use Koha::Database;
 
+use Bytes::Random::Secure;
 use Carp;
 use Module::Load;
 use String::Random;
@@ -432,18 +433,20 @@ sub _gen_datetime {
 sub _gen_text {
     my ($self, $params) = @_;
     # From perldoc String::Random
-    # max: specify the maximum number of characters to return for * and other
-    # regular expression patters that don't return a fixed number of characters
-    my $regex = '[A-Za-z][A-Za-z0-9_]*';
-    my $size = $params->{info}{size};
-    if ( defined $size and $size > 1 ) {
-        $size--;
-    } elsif ( defined $size and $size == 1 ) {
-        $regex = '[A-Za-z]';
-    }
-    my $random = String::Random->new( max => $size );
-    my $text = $random->randregex($regex);
-    return $text;
+    my $size = $params->{info}{size} // 10;
+    $size -= alt_rand(0.5 * $size);
+    my $regex = $size > 1
+        ? '[A-Za-z][A-Za-z0-9_]{'.($size-1).'}'
+        : '[A-Za-z]';
+    my $random = String::Random->new( max => $size, rand_gen => \&alt_rand );
+    return $random->randregex($regex);
+}
+
+sub alt_rand { #Alternative randomizer
+    my ($max) = @_;
+    my $random = Bytes::Random::Secure->new( NonBlocking => 1 );
+    my $r = $random->irand / 2**32;
+    return int( $r * $max );
 }
 
 sub _gen_set_enum {
-- 
2.39.5