From 58bec27564ad92a19ce2eed71f49f3630dbd7c98 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Mon, 27 Apr 2020 21:41:08 +0000 Subject: [PATCH] Bug 25282: Correct Bootstrap dropdown button markup Incorrect markup surrounding Bootstrap dropdown buttons causes display problems with the buttons are in a DataTable. Dropdown wrapper
s must have a "btn-group" class. To reproduce the problem, look at the MARC bibliographic frameworks page. The "Actions" menu when triggered will not line up with the button. In almost all cases, dropdown buttons inside tables should also have the "dropup" class on their wrapper so that the menu appears above the button. This prevents the menu from disappearing off the bottom of the window when the button is positioned low in the viewport. To test, apply the patch and test the button menus in tables on the following pages: - Acquisitions -> Invoices - Acquisitions -> Add to order -> From external source -> Results - Acquisitions -> Suggestions - Administration -> Budgets - Administration -> Funds - Administration -> Authority types - Administration -> Authority types -> MARC structure - Administration -> MARC bibliographic frameworks - Administration -> MARC bibliographic frameworks -> MARC structure - Administration -> OAI sets configuration - Administration -> Z39.50/SRU servers - Authorities -> Authority search results - Authorities -> New from Z39.50/SRU -> Search results - Cataloging -> Edit items - Cataloging -> New from Z39.50/SRU -> Search results - Circulation -> Article requests - Reports -> Saved reports - Tools -> Patron lists - Tools -> Rotating collections - Serials -> Serials search results Signed-off-by: Phil Ringnalda Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize --- .../prog/en/modules/acqui/invoices.tt | 2 +- .../prog/en/modules/acqui/z3950_search.tt | 2 +- .../prog/en/modules/admin/aqbudgetperiods.tt | 2 +- .../prog/en/modules/admin/aqbudgets.tt | 2 +- .../en/modules/admin/auth_tag_structure.tt | 2 +- .../prog/en/modules/admin/authtypes.tt | 2 +- .../prog/en/modules/admin/biblio_framework.tt | 4 +- .../prog/en/modules/admin/marctagstructure.tt | 2 +- .../prog/en/modules/admin/oai_sets.tt | 2 +- .../prog/en/modules/admin/z3950servers.tt | 2 +- .../modules/authorities/searchresultlist.tt | 2 +- .../prog/en/modules/cataloguing/additem.tt | 2 +- .../modules/cataloguing/z3950_auth_search.tt | 2 +- .../en/modules/cataloguing/z3950_search.tt | 2 +- .../prog/en/modules/circ/article-requests.tt | 2 +- .../prog/en/modules/patron_lists/lists.tt | 2 +- .../modules/reports/guided_reports_start.tt | 46 +++++++++---------- .../rotatingCollections.tt | 2 +- .../prog/en/modules/serials/serials-search.tt | 2 +- .../prog/en/modules/suggestion/suggestion.tt | 4 +- 20 files changed, 42 insertions(+), 46 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt index 458112e011..5b8b34fad0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoices.tt @@ -74,7 +74,7 @@ -
+
Actions diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt index ad836fefd3..2a44479ff7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt @@ -136,7 +136,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : [% END %] -
+
Preview diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt index c22bec5624..3af08680ce 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgetperiods.tt @@ -4,7 +4,7 @@ [% USE Price %] [% SET footerjs = 1 %] [%- BLOCK action_menu %] -
+
Actions diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt index f8e985cd4a..349c1cef4a 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/aqbudgets.tt @@ -170,7 +170,7 @@ [% ELSE %] -
+
Actions diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt index 40cf5c50dd..c6b95b17b4 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/auth_tag_structure.tt @@ -208,7 +208,7 @@ [% IF ( loo.mandatory ) %]Yes[% ELSE %]No[% END %] [% loo.authorised_value | html %] -
+
Actions