From 74165f986e67376360cf7d2871936bcdabe7edc3 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Thu, 17 Oct 2019 15:12:46 +0000
Subject: [PATCH] Bug 23791: (follow-up) Add missing CSS changes

This patch adds OPAC CSS changes which were missing from the original
patch. It also adds a missing title attribute to the Twitter link.

To test, apply the patch and regenerate the OPAC SCSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).

Follow the previous test plan.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
---
 .../opac-tmpl/bootstrap/css/src/opac.scss     | 35 ++++++++++---------
 .../bootstrap/en/modules/opac-detail.tt       |  2 +-
 2 files changed, 20 insertions(+), 17 deletions(-)

diff --git a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
index 5e324feaac..6e6d3801d0 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
+++ b/koha-tmpl/opac-tmpl/bootstrap/css/src/opac.scss
@@ -2020,12 +2020,20 @@ input {
 }
 
 #social_networks {
+    margin-top: .5em;
+
     a {
-        background: transparent url( "../images/social-sprite.png" ) no-repeat;
-        display: block;
-        height: 20px !important;
-        text-indent: -999em;
-        width: 20px;
+        border: 1px solid transparent;
+        border-radius: 4px;
+        display: inline-block;
+        min-width: 1em;
+        padding: .5em;
+        text-align: center;
+    }
+
+    a:hover,
+    a:active {
+        border: 1px solid #EEE;
     }
 
     span {
@@ -2035,32 +2043,27 @@ input {
         font-size: 85%;
         font-weight: bold;
         line-height: 2em;
-        margin: .5em 0 .5em .5em !important;
+        margin: .5em;
     }
 
     div {
-        float: left !important;
-        margin: .5em 0 .5em .2em !important;
+        float: left;
     }
 
     #facebook {
-        background-position: -7px -35px;
+        color: #4267B2;
     }
 
     #twitter {
-        background-position: -7px -5px;
+        color: #1DA1F2;
     }
 
     #linkedin {
-        background-position: -7px -95px;
-    }
-
-    #delicious {
-        background-position: -7px -66px;
+        color: #0073b0;
     }
 
     #email {
-        background-position: -7px -126px;
+        color: #666;
     }
 }
 
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
index 08b1c1d936..4c2541c32f 100644
--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
@@ -1165,7 +1165,7 @@
                                 [% CASE "email" -%]
                                     <div><a id="email" href="mailto:?subject=[% title |url %]&amp;body=[% title |url %]%20([% current_url |url %])" title="Share by email"><i class="fa fa-envelope-o"></i></a></div>
                                 [% CASE "twitter" -%]
-                                    <div><a id="twitter" href="https://twitter.com/share" class="twitter-share-button" data-count="none" data-text="[% title |url %]" data-lang="[% lang | html %]"><i class="fa fa-twitter"></i></a></div>
+                                    <div><a id="twitter" href="https://twitter.com/share" class="twitter-share-button" data-count="none" data-text="[% title |url %]" data-lang="[% lang | html %]" title="Share on Twitter"><i class="fa fa-twitter"></i></a></div>
                             [% END -%]
                         [% END %]
                     </div>
-- 
2.39.5