From 7efc10542be6d836c52cf598174e28f84a9d6470 Mon Sep 17 00:00:00 2001 From: Galen Charlton Date: Wed, 19 Feb 2014 20:04:22 +0000 Subject: [PATCH] Bug 11644: (follow-up) add FIXME Arithmetic with monetary amounts is a *hard* problem -- or if not hard, at least super-fiddly, particularly since in theory a Koha database could have to deal with dozens of currencies if used by a large research library. This patch adds a FIXME implicitly commenting on the poor state of affairs of available monetary calculation modules on CPAN. Signed-off-by: Galen Charlton --- admin/check_parent_total.pl | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/admin/check_parent_total.pl b/admin/check_parent_total.pl index 653a9f2b0b..ce7453a99f 100755 --- a/admin/check_parent_total.pl +++ b/admin/check_parent_total.pl @@ -96,6 +96,10 @@ else { $budget_period_unalloc = $period->{'budget_period_total'} - $period_sum->{'sum'} if $period->{'budget_period_total'}; } +# FIXME - we really need a better way to do this consistently +# and across the board, be it bigints, Math::FixedPoint, a +# modernized version of Math::Curency that isn't tied to the system +# locale, or something else. $total = sprintf( "%.2f", $total ); $sub_unalloc = sprintf( "%.2f", $sub_unalloc ); $budget_period_unalloc = sprintf( "%.2f", $budget_period_unalloc ); -- 2.39.5