From 8c094e2dc3413425f1ddfe6e518221749f9373c4 Mon Sep 17 00:00:00 2001
From: Lari Taskula <lari.taskula@jns.fi>
Date: Mon, 2 Oct 2017 19:06:23 +0300
Subject: [PATCH] Bug 19400: Reminder to unset gone no address flag after
 patron makes a modification request

Our librarians requested a reminder to unset "gone no address" flag from patron's
record once the patron has made a modification request to update their address.

I propose adding a message box under patron modification request to notify
librarians about patrons that have gone no address flag on, and an option to
unset the flag without the need of having to navigate into patron's details.

To test:
1. Apply patch
2. Set "Gone no address" flag for your test patron. You can do this by going
   to patron modification screen in staff client.
3. Go to OPAC with your test patron
4. Make a modification request for your personal details
5. Go to staff client and see pending modification requests
6. Open the request you just created
7. Observe a message dialog that says this patron has gone no address flag set
8. Check the checkbox to unset the flag and approve the modification request
9. Click Submit
10. Observe your test patron no longer has gone no address flag set
11. Repeat steps 2-7
12. Do not check the checkbox, but approve the modification request
13. Observe your test patron still has gone no address flag set
14. Remove the gone no address flag from your test patron
15. Repeat steps 3-6
16. Observe there is no message dialog for gone no address

Followed test plan, patch worked as described. Also ran QA test tools
and all modified files passed

Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/members/members-update.tt            | 8 ++++++++
 members/members-update-do.pl                             | 9 +++++++++
 2 files changed, 17 insertions(+)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
index 40fc42d26c..39a59822ba 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/members-update.tt
@@ -166,6 +166,14 @@
                                         </table>
                                     </div>
                                   [%  END %]
+                                  [% IF borrowers.$borrowernumber.gonenoaddress > 0 %]
+                                    <div class="dialog message" style="margin-top:.8em">
+                                        <h4>Patron's address in doubt</h4>
+                                        <p>The <strong>Gone no address</strong> flag is set for this patron. If this modification request resolves the issue, please unset the flag.</p>
+                                        <input type="checkbox" id="unset_gna_[% pm.borrowernumber %]" name="unset_gna_[% pm.borrowernumber %]" value="unset_gna_[% pm.borrowernumber %]"/>
+                                        <label for="unset_gna_[% pm.borrowernumber %]">Unset Gone no address for this patron</label>
+                                    </div>
+                                  [% END %]
                                 </div>
                             [% END %]
                         </div>
diff --git a/members/members-update-do.pl b/members/members-update-do.pl
index 6a6e8268d6..bd1757f019 100755
--- a/members/members-update-do.pl
+++ b/members/members-update-do.pl
@@ -49,6 +49,15 @@ foreach my $param (@params) {
 
         if ( $action eq 'approve' ) {
             my $m = Koha::Patron::Modifications->find( { borrowernumber => $borrowernumber } );
+
+            if ($query->param("unset_gna_$borrowernumber")) {
+                # Unset gone no address
+                ModMember(
+                    borrowernumber => $borrowernumber,
+                    gonenoaddress  => undef
+                );
+            }
+
             $m->approve() if $m;
         }
         elsif ( $action eq 'deny' ) {
-- 
2.39.5