From 90090a3601ae06ff070830827fad319f8b2f8cf2 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Wed, 17 Nov 2021 15:48:48 +0100
Subject: [PATCH] Bug 29496: (bug 27526 follow-up) Fix item form validation

The validation of the forms were blocked with "X item mandatory fields
empty" when at least one dropdown list subfield was marked as mandatory.

We need to add the 'input_marceditor' class to the select (does it
actually make sense? select vs input...)

Caused by
  commit 6ed29bccef590a1bc5e4cea175b41b8024483320
  Bug 27526: Fix mandatory and important checks
Which lamentably failed as it was stating:
"Using .input_marceditor let us fix the additem.tt form and prevent to break the other ones"

Signed-off-by: Marion Durand <marion.durand@biblibre.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt      | 2 +-
 .../intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
index d80aaef044..9ae96ef3a3 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
@@ -295,7 +295,7 @@ Batch list
                                         [% END %]
 
                                         [% IF ( iteminformatio.marc_value.type == 'select' ) %]
-                                            <select name="field_value">
+                                            <select name="field_value" class="input_marceditor">
                                             [% FOREACH value IN iteminformatio.marc_value.values %]
                                                 [% IF ( value == iteminformatio.marc_value.default ) %]
                                                     <option value="[% value | html %]" selected="selected">[% iteminformatio.marc_value.labels.$value | html %]</option>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt
index cff769758b..c8a3b1fd24 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/services/itemrecorddisplay.tt
@@ -13,7 +13,7 @@
             <label>[% iteminfo.subfield | html %] - [% iteminfo.marc_lib | $raw %]</label>
         [% END %]
         [% IF ( iteminfo.marc_value.type == 'select' ) %]
-        <select name="field_value">
+        <select name="field_value" class="input_marceditor">
         [% FOREACH value IN iteminfo.marc_value.values %]
           [% IF ( value == iteminfo.marc_value.default ) %]
             <option value="[% value | html %]" selected="selected">[% iteminfo.marc_value.labels.$value | html %]</option>
-- 
2.39.5