From 957e65c748359e5dbbed176b564a578d84479821 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 5 Feb 2015 12:19:38 -0500 Subject: [PATCH] Bug 13672 - OPAC locks up browser when browsing items from series link with NoveList and OpacHighlightedWords It appears that an empty string is sneaking into the list of words to highlight and that is causing the browser to freak out. Test Plan: 1) Enable NoveList 2) Enable OpacHighlightedItems 3) Search a title with a series (i.e. The Hunger Games) 4) Click into the record 5) Click on the series to search it 6) Click on a title in the search results 7) If Firefox doesn't crash, it gives the unresponsive script message 8) Apply this patch 9) Repeat steps 3-6 10) Browser doesn't freak our Signed-off-by: Jason Robb Signed-off-by: Katrin Fischer could not confirm the problem, but small change and highlighting terms on result list and couldn't find any regressions in highlighting. Signed-off-by: Tomas Cohen Arazi --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 1 + 1 file changed, 1 insertion(+) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt index 71b022b39f..3e5364faef 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt @@ -1434,6 +1434,7 @@ [% IF ( query_desc ) %][% IF ( OpacHighlightedWords ) %]var query_desc = "[% query_desc |replace("'", "\'") |replace('\n', '\\n') |replace('\r', '\\r') |html %]"; q_array = query_desc.split(" "); + q_array = q_array.filter(function(n){ return n }); // Remove empty strings highlightOn(); $("#highlight_toggle_on" ).hide().click(function() {highlightOn() ; return false;}); $("#highlight_toggle_off").show().click(function() {highlightOff(); return false;});[% END %][% END %] -- 2.39.5