From 9ddb312749c34fc4d1c19d48570725978c813bbd Mon Sep 17 00:00:00 2001
From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Date: Fri, 9 Oct 2020 11:28:12 +0100
Subject: [PATCH] Bug 23695: (QA follow-up) Revert 'Orginating library' option

At my request, we added an 'Originating library' option to the manual
transfers form.

However, we did not properly pass this through in the controller and I
have since discovered that my request was ill conceived/a
misunderstanding of requirements.

This patch removes the option from the template and drops the references
to it in the controller.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 circ/branchtransfers.pl                                   | 2 --
 .../intranet-tmpl/prog/en/modules/circ/branchtransfers.tt | 8 --------
 2 files changed, 10 deletions(-)

diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl
index f64d37fc76..ff59c03a5a 100755
--- a/circ/branchtransfers.pl
+++ b/circ/branchtransfers.pl
@@ -79,7 +79,6 @@ my $setwaiting;
 
 my $request        = $query->param('request')        || '';
 my $borrowernumber = $query->param('borrowernumber') ||  0;
-my $frombranchcd   = $query->param('frombranchcd')   || C4::Context->userenv->{'branch'};
 my $tobranchcd     = $query->param('tobranchcd')     || '';
 
 my $ignoreRs = 0;
@@ -223,7 +222,6 @@ $template->param(
     itemnumber              => $itemnumber,
     barcode                 => $barcode,
     biblionumber            => $biblionumber,
-    frombranchcd            => $frombranchcd,
     tobranchcd              => $tobranchcd,
     reqmessage              => $reqmessage,
     cancelled               => $cancelled,
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
index 7996c8fffd..706211ec2e 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/branchtransfers.tt
@@ -72,7 +72,6 @@
                             <input type="hidden" name="biblionumber" value="[% biblionumber | html %]" />
                             <input type="hidden" name="borrowernumber" value="[% borrowernumber | html %]" />
                             <input type="hidden" name="tobranchcd" value="[% tobranchcd | html %]" />
-                            <input type="hidden" name="frombranchcd" value="[% frombranchcd | html %]" />
                             <input type="hidden" name="barcode" value="[% barcode | html %]" />
                             <input type="hidden" name="request" value="KillReserved" />
                             <input type="submit" value="Cancel" />
@@ -152,13 +151,6 @@
         <fieldset class="brief">
             <legend>Transfer</legend>
             <ol>
-			<li>
-                <label for="frombranchcd">Originating library: </label>
-                    <select name="frombranchcd" id="frombranchcd">
-                        <option value="current_holding">Item's holding branch</option>
-                        [% PROCESS options_for_libraries libraries => Branches.all( selected => '', unfiltered => 1) %]
-                    </select>
-            </li>
             <li>
                 <label for="tobranchcd">Destination library: </label>
                     <select name="tobranchcd" id="tobranchcd">
-- 
2.39.5