From aa6457f38f33df9e01a554165bcd1f6f075b4cd2 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 8 Mar 2016 14:40:02 -0500
Subject: [PATCH] Bug 16061: Use Font Awesome icons in reports when filter
 returns no results
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

In Reports -> Saved reports, when the filter form returns no results a
dialog is shown. This patch updates the dialog to use Font Awesome
icons.

Also changed: The dialog now includes a button for creating a new SQL
report, not just one to create a new guided report. The "clear" link in
the sidebar has been modified to pass HTML validation.

To test, apply the patch and go to Reports -> Saved reports.

- In the left-hand sidebar filter, submit terms which will return no
  results.
- Verify that the resulting dialog is correctly styled.
- Confirm that all three buttons in the dialog work correctly: New
  guided report, new SQL report, and Cancel.

Signed-off-by: Marc Véron <veron@veron.ch>
Signed-off-by: Tomas Cohen Arazi <tomascohen@unc.edu.ar>
I'm passing this one, while I don't like it is hardcoding a URL path,
because it will make is easier to spot it when time comes and we
make Koha delpoyable in any endpoint.

Signed-off-by: Brendan Gallagher brendan@bywatersolutions.com
---
 .../prog/en/modules/reports/guided_reports_start.tt   | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
index d766381977..0a7d80ffbe 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
@@ -378,14 +378,19 @@ canned reports and writing custom SQL reports.</p>
     [% IF ( CAN_user_reports_create_reports ) %]
     <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get">
     <input type="hidden" name="phase" value="Build new" />
-    <input type="submit" class="edit" value="Build a new report" accesskey="y" />
+        <button type="submit" class="new"><i class="fa fa-plus"></i> New guided report</button>
+    </form>
+
+    <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get">
+        <input type="hidden" name="phase" value="Create report from SQL" />
+        <button type="submit" class="new"><i class="fa fa-plus"></i> New SQL report</button>
     </form>
 
     <form action="/cgi-bin/koha/reports/guided_reports.pl" method="get">
     <input type="hidden" name="phase" value="Use saved" />
     <input type="hidden" name="filter_set" value="1" />
     <input type="hidden" name="filter_keyword" value="" />
-    <input type="submit" class="deny" value="Cancel filter" accesskey="n" />
+        <button type="submit" class="deny"><i class="fa fa-fw fa-remove"></i> Cancel filter</button>
     </form>
 
     [% END %]
@@ -1031,7 +1036,7 @@ Sub report:<select name="subreport">
   </fieldset>
   <fieldset class="action">
     <input type="submit" value="Apply filter" />
-    <a id="resetReportsFilter" href="?phase=Use saved&clear_filters=1">Clear</a>
+    <a id="resetReportsFilter" href="/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved&clear_filters=1">Clear</a>
   </fieldset>
 </form>
 </div>
-- 
2.39.5