From b0342302a0d70dbad25c0f2c2970a0957ec34bf2 Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Tue, 5 Sep 2023 17:06:51 +0000
Subject: [PATCH] Bug 34380: Fix inconsistencies in Item types page titles,
 breadcrumbs, and header
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

This patch fixes inconsistencies in the item type administration page so
that page titles, breadcrumb navigation, and page headers are consistent
with each other and with other pages in Koha.

To test, apply the patch and go to Administration -> Item types. Check
each variation of the page to confirm that everything looks correct:

- Item types list
 - New item type
 - Edit item type
 - Confirm deletion of item type

Signed-off-by: Émily-Rose Francoeur <emily-rose.francoeur@inLibro.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
---
 .../prog/en/modules/admin/itemtypes.tt         | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
index b59fe3e45a..5a093affbe 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt
@@ -13,14 +13,14 @@
         [% IF ( itemtype ) %]
             [% tx("Modify item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
         [% ELSE %]
-            [% t("Add item type") | html %]
+            [% t("New item type") | html %]
         [% END %] &rsaquo;
     [% END %]
     [% IF op == 'delete_confirm' %]
         [% IF ( total ) %]
             [% tx("Cannot delete item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
         [% ELSE %]
-            [% tx("Delete item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]
+            [% tx("Confirm deletion of item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]
         [% END %] &rsaquo;
     [% END %]
     [% IF op == 'delete_confirmed' %]
@@ -72,11 +72,11 @@
         [% IF op == 'add_form' %]
             [% IF itemtype %]
                [% WRAPPER breadcrumb_item bc_active= 1 %]
-                    <span>Modify item type '[% itemtype.itemtype | html %]'</span>
+                    [% tx("Modify item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
                 [% END %]
             [% ELSE %]
                [% WRAPPER breadcrumb_item bc_active= 1 %]
-                    <span>Add item type</span>
+                    <span>New item type</span>
                 [% END %]
             [% END %]
         [% END %]
@@ -84,11 +84,11 @@
         [% IF op == 'delete_confirm' %]
             [% IF total %]
                [% WRAPPER breadcrumb_item bc_active= 1 %]
-                    <span>Cannot delete item type '[% itemtype.itemtype | html %]'</span>
+                    [% tx("Cannot delete item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]
                 [% END %]
             [% ELSE %]
                [% WRAPPER breadcrumb_item bc_active= 1 %]
-                    <span>Delete item type '[% itemtype.itemtype | html %]'?</span>
+                    [% tx("Confirm deletion of item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]
                 [% END %]
             [% END %]
         [% END %]
@@ -144,9 +144,9 @@
 
 [% IF op == 'add_form' %]
     [% IF itemtype %]
-        <h1>Modify item type</h1>
+        <h1>[% tx("Modify item type '{item_type}'", { item_type = itemtype.itemtype }) | html %]</h1>
     [% ELSE %]
-        <h1>Add item type</h1>
+        <h1>New item type</h1>
     [% END %]
     <form action="/cgi-bin/koha/admin/itemtypes.pl" name="Aform" method="post" id="itemtypeentry">
         <input type="hidden" name="op" value="add_validate" />
@@ -354,7 +354,7 @@
 
 [% IF op == 'delete_confirm' %]
     <div class="dialog alert">
-        <h1>Delete item type '[% itemtype.itemtype | html %]'?</h1>
+        <h1>[% tx("Are you sure you want to delete item type '{item_type}'?", { item_type = itemtype.itemtype }) | html %]</h1>
         <table>
             <tr>
                 <th scope="row">Item type</th>
-- 
2.39.5