From bc09af634c92dc83f4eb28761bcff428481f6daf Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 2 Aug 2017 11:52:11 -0300 Subject: [PATCH] Bug 19025: Remove C4::Reserves::GetReserveInfo Test plan: git grep GetReserveInfo should not return results Signed-off-by: Marcel de Rooy Signed-off-by: Jonathan Druart --- C4/Reserves.pm | 54 -------------------------------------------------- 1 file changed, 54 deletions(-) diff --git a/C4/Reserves.pm b/C4/Reserves.pm index 04bd7d9d36..c3b21264f9 100644 --- a/C4/Reserves.pm +++ b/C4/Reserves.pm @@ -108,7 +108,6 @@ BEGIN { &GetReservesForBranch &GetReservesToBranch &GetReserveCount - &GetReserveInfo &GetReserveStatus &GetOtherReserves @@ -1231,59 +1230,6 @@ sub ModReserveMinusPriority { _FixPriority({ reserve_id => $reserve_id, rank => '0' }); } -=head2 GetReserveInfo - - &GetReserveInfo($reserve_id); - -Get item and borrower details for a current hold. -Current implementation this query should have a single result. - -=cut - -sub GetReserveInfo { - my ( $reserve_id ) = @_; - my $dbh = C4::Context->dbh; - my $strsth="SELECT - reserve_id, - reservedate, - reservenotes, - reserves.borrowernumber, - reserves.biblionumber, - reserves.branchcode, - reserves.waitingdate, - notificationdate, - reminderdate, - priority, - found, - firstname, - surname, - phone, - email, - address, - address2, - cardnumber, - city, - zipcode, - biblio.title, - biblio.author, - items.holdingbranch, - items.itemcallnumber, - items.itemnumber, - items.location, - barcode, - notes - FROM reserves - LEFT JOIN items USING(itemnumber) - LEFT JOIN borrowers USING(borrowernumber) - LEFT JOIN biblio ON (reserves.biblionumber=biblio.biblionumber) - WHERE reserves.reserve_id = ?"; - my $sth = $dbh->prepare($strsth); - $sth->execute($reserve_id); - - my $data = $sth->fetchrow_hashref; - return $data; -} - =head2 IsAvailableForItemLevelRequest my $is_available = IsAvailableForItemLevelRequest($item_record,$borrower_record); -- 2.39.5