From cc501af15082f3da329d0557b337dce944626511 Mon Sep 17 00:00:00 2001 From: Josef Moravec Date: Wed, 20 Mar 2019 15:29:32 +0000 Subject: [PATCH] Bug 13795: Remove occurences of unused columns in code These patch removes these two columns from backfill_statstics script and from columns.def - this file is used to create description in guided reports Test plan: 1. Run installer/data/mysql/backfull_statistics.pl --> without this patch, there are associatedborrower and usercode errors reported --> with patch, these two columns are not reported Signed-off-by: Michal Denar Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- installer/data/mysql/backfill_statistics.pl | 2 -- koha-tmpl/intranet-tmpl/prog/en/columns.def | 1 - 2 files changed, 3 deletions(-) diff --git a/installer/data/mysql/backfill_statistics.pl b/installer/data/mysql/backfill_statistics.pl index 8308b6bfdd..daa8e831ad 100755 --- a/installer/data/mysql/backfill_statistics.pl +++ b/installer/data/mysql/backfill_statistics.pl @@ -24,9 +24,7 @@ sub get_counts() { (SELECT count(*) FROM statistics WHERE branch="NO_LIBRARY" ) AS NO_LIBRARY, (SELECT count(*) FROM statistics WHERE branch IS NULL) AS NULL_BRANCH, (SELECT count(*) FROM statistics WHERE itemtype IS NULL AND itemnumber IS NOT NULL) AS NULL_ITEMTYPE, - (SELECT count(*) FROM statistics WHERE usercode IS NULL) AS NULL_USERCODE, (SELECT count(*) FROM statistics WHERE borrowernumber IS NULL) AS NULL_BORROWERNUMBER, - (SELECT count(*) FROM statistics WHERE associatedborrower IS NULL) AS NULL_ASSOCIATEDBORROWER, (SELECT count(*) FROM statistics ) AS Total ); my $sth = $dbh->prepare($query); diff --git a/koha-tmpl/intranet-tmpl/prog/en/columns.def b/koha-tmpl/intranet-tmpl/prog/en/columns.def index 70733607ed..05112eb704 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/columns.def +++ b/koha-tmpl/intranet-tmpl/prog/en/columns.def @@ -111,7 +111,6 @@ Value Type -User code Item number Itemtype Borrower number -- 2.39.5