From d42974f5bb2cae2f05ec388dab662cdee18f9840 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Fri, 30 Aug 2019 12:25:45 +0000 Subject: [PATCH] Bug 23518: Problem with borrower search autocomplete This patch fixes a bug introduced by my patch for Bug 23405: Keyboard navigation of patron autocomplete results was broken because I incorrectly assumed that the autocomplete "select" action was redundant because keyboard navigation would trigger the selected link. It doesn't! This patch adds the "select" action back to the autocomplete configuration, explicitly defining a redirect to match the URL which is followed if the user uses the mouse to click a result. To test you should have a patron in your database which has no card number. Make sure CircAutocompl is enabled. - From the circulation home page, type a patron name in the "Check out" form and wait for autocomplete search results to display. - Making a selection from the autocomplete results should work by clicking with a mouse OR using the arrow keys and TAB or ENTER. - Test with patrons with and without card numbers. Signed-off-by: Nick Clemens Signed-off-by: Michal Denar Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize (cherry picked from commit b94b58aa746188ee3699a2e4bc0a6b24d2dd86c5) Signed-off-by: Fridolin Somers (cherry picked from commit fec88c6414a7269a91d07388c00784c09bbb0494) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc index d64f6bb580..1e2060a119 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/js_includes.inc @@ -95,9 +95,13 @@ var obj = $( "#findborrower" ).autocomplete({ source: "/cgi-bin/koha/circ/ysearch.pl", minLength: 3, + select: function( event, ui ) { + window.location.href = ui.item.link; + } }).data( "ui-autocomplete" ); if( obj ) { obj._renderItem = function( ul, item ) { + item.link = "/cgi-bin/koha/circ/circulation.pl?borrowernumber=" + item.borrowernumber; var cardnumber = ""; if( item.cardnumber != "" ){ // Display card number in parentheses if it exists @@ -105,7 +109,7 @@ } return $( "
  • " ) .data( "ui-autocomplete-item", item ) - .append( "" + item.surname + ", " + item.firstname + cardnumber + " " + item.dateofbirth + " " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "" ) + .append( "" + item.surname + ", " + item.firstname + cardnumber + " " + item.dateofbirth + " " + item.address + " " + item.city + " " + item.zipcode + " " + item.country + "" ) .appendTo( ul ); }; } -- 2.39.5